Add OIDC id_token to token response for openid scope#54
Merged
Conversation
Per OIDC Core Section 3.1.3.3, the token response must include an id_token when the openid scope is requested. The ID token is a JWT with: - aud = client_id (not the resource server audience) - at_hash = left half of SHA-256 of the access token (Section 3.1.3.6) - Scope-gated claims: email/email_verified (email scope), preferred_username/given_name/family_name/picture (profile scope) - Empty claims omitted via omitempty The id_token is not included for flows without openid scope (e.g. client_credentials with admin scopes). Closes #52 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The JWT aud claim is serialized as a JSON array ["client_id"], not a plain string. Updated the assertion to unpack the array first. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_tokenJWT when theopenidscope is requested, per OIDC Core Section 3.1.3.3client_id(not the resource server audience used for access tokens)at_hash(left half of SHA-256 of the access token, per Section 3.1.3.6)email/email_verifiedrequireemailscope,preferred_username/given_name/family_name/picturerequireprofilescopeomitemptyopenidscope (e.g.client_credentialswith admin scopes)Closes #52
Test plan
go build ./...andgo vet ./...passTestGenerateIDTokenandTestGenerateIDToken_OmitsEmptyClaimsTestTokenResponseIncludesIDTokenandTestTokenResponseIDTokenAbsentWithoutOpenID(require Docker)omitempty)🤖 Generated with Claude Code