Add consent screen for OAuth authorization#75
Merged
1 commit merged intoApr 3, 2026
Merged
Conversation
Users now see a consent page showing the client name and requested permissions before granting access. This addresses a trust and transparency gap — previously, authenticated users were silently redirected to clients with an authorization code and no opportunity to review or deny the request. Key changes: - New `oauth_user_consents` table stores per-user, per-client consent with granted scopes. Consent is remembered so users aren't re-prompted unless the client requests new scopes. - New consent page (`/oauth/consent`) using existing DaisyUI card pattern, showing the client name and human-readable scope descriptions with Allow/Deny buttons. - Deny redirects to client with `error=access_denied` per RFC 6749. - HandleOauthAuthorize now checks stored consent before generating an authorization code. If consent is missing or doesn't cover the requested scopes, the user is redirected to the consent page. - login.go and mfa.go refactored to redirect back to /oauth/authorize after establishing a session, instead of generating auth codes directly. This centralizes all consent + code generation logic. - All existing tests updated to handle the new consent step. Added mustLoginAndConsent helper for inline OAuth flows. Closes #64. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a consent screen to the OAuth authorization flow. Users now see the client application name and requested permissions (with human-readable descriptions) before granting access, with Allow and Deny buttons.
oauth_user_consentstable. Users are only re-prompted when a client requests scopes not previously consented to.error=access_deniedper RFC 6749 4.1.2.1./oauth/authorizeafter establishing a session, instead of generating auth codes directly. This centralizes all consent + code generation logic in one place.Scope descriptions shown to users
openidprofileemailMigration
Migration
000009adds theoauth_user_consentstable. Must be run before deploying.Test plan
5 new consent-specific tests (written red/green TDD):
TestConsentScreenShownOnFirstAuthorize— redirects to/oauth/consentinstead of straight to clientTestConsentApproveGeneratesCode— approving consent generates auth codeTestConsentDenyRedirectsWithError— denying returnserror=access_deniedTestConsentRemembered— second authorize with same scopes skips consentTestConsentRePromptedForNewScopes— requesting new scopes shows consent againAll 109 tests pass (existing tests updated to handle consent step).
Closes #64.
🤖 Generated with Claude Code