Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VihasMakwana The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com>
Signed-off-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.2.0 to 6.3.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@7a3fe6c...4b73464) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
/ok-to-test |
|
@VihasMakwana: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
3 participants
tx.checkis called in a goroutine insidetx.Checkwhen using strict mode.tx.checkperforms checks on page flags and page id and it panics in the goroutine if type the database is corrupted. This panic, however, is not recovered and can cause the entire process to crash.This PR adds
recovercall and passes the error to the caller.Testing
I have added a unit test for this fix. This test would fail without the recover.