cmd/bbolt: write bench results to stdout#767
Conversation
Signed-off-by: Ivan Valdes <ivan@vald.es>
|
I think the reason it has split pipes is to not have the progress output mingled together with the result output. Maybe we should swap those? As for it being a breaking change, I think that's a rather minor breakage... I'm not even sure if anyone else besides us is using the command. |
My understanding is that we only print errors and usage to |
@tjungblu, I'm sorry, I may not have understood you. Are you suggesting sending progress and errors to
@ahrtr, I don't know if my point of view is biased or opinionated, but it makes sense to me that only the application's actual output goes to For example, if I want to pipe or use the results from a ./bbolt bench -gobench-output -write-mode rnd -read-mode seq 2>/dev/null | grep ^Benchmark | tee result.txt
# vs.
./bbolt bench -gobench-output -write-mode rnd -read-mode seq 2>/dev/null | tee result.txt
benchstat result.txt result-old.txt ... |
Sounds good to me. |
|
/lgtm |
backport of etcd-io#767 to fix the missing output on nightly benchmarks Co-authored-by: Iván Valdés Castillo <iv@nvald.es> Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Follow-up on #765, and work towards #750 and #739.
This PR changes the output of the
benchresults tostdoutrather thanstderrfor ease of working with the output.However, I'm unsure if we would consider this a breaking change. If we want to delay this change, I can work around this.