Merged
Conversation
belltoy
force-pushed
the
feature/auth-interceptor
branch
7 times, most recently
from
c6181ab to
ef93b18
Compare
belltoy
force-pushed
the
feature/auth-interceptor
branch
3 times, most recently
from
ef93b18 to
7d5547c
Compare
belltoy
force-pushed
the
feature/auth-interceptor
branch
from
7d5547c to
0c171e5
Compare
belltoy
force-pushed
the
feature/auth-interceptor
branch
from
0c171e5 to
9783087
Compare
belltoy
force-pushed
the
feature/auth-interceptor
branch
from
9783087 to
c491fcd
Compare
belltoy
force-pushed
the
master
branch
2 times, most recently
from
9a46eb1 to
2e99c37
Compare
It is ok to keep user credentials in the client options. For now, the application still needs to invoke `refresh_token` manually. Add an `update_user` method for Client. This method allows applications to update the etcd user credentials in-flight.
belltoy
force-pushed
the
feature/auth-interceptor
branch
from
c491fcd to
a3fbd0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a named interceptor instead of a wrapped service to do authentication.