Skip to content

feat(usfm): preserve section headings through import and export - #319

Closed
henrique221 wants to merge 4 commits into
feat/419-usfm-import-createfrom
codex/288-section-heading-storage
Closed

henrique221 wants to merge 4 commits into
feat/419-usfm-import-createfrom
codex/288-section-heading-storage

Conversation

@henrique221

Copy link
Copy Markdown
Contributor

USFM import could append a section heading to the previous verse, and chapter content could drop stored headings. I now keep supported titles in the existing markers.headings field and preserve their order through import, editing, chapter content and export. Export also adds a body paragraph after a heading when needed, keeping scripture text outside the heading.

This is a draft stacked on #305 because the import path is not on main yet. Please retarget this PR to main before merging #305, since merged branches are deleted automatically. No new migration or route is required. Refs #288; the web fix is eten-tech-foundation/fluent-web#432.

Validation: all 607 tests passed, plus lint, formatting, typecheck, build and the docs check. An isolated PostgreSQL 16 smoke passed for immediate and delayed imports, saved edits, chapter content, export, empty titled verses, retries without overwrites and compatibility with legacy semantic-division records. Lint has three existing file-length warnings. The full pre-merge workflow does not run for a draft targeting the import branch.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 527d2ff4-942e-46fa-82e1-1c2b0090ead7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant