feat(usfm): preserve section headings through import and export - #319
Closed
henrique221 wants to merge 4 commits into
Closed
henrique221 wants to merge 4 commits into
henrique221 wants to merge 4 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USFM import could append a section heading to the previous verse, and chapter content could drop stored headings. I now keep supported titles in the existing
markers.headingsfield and preserve their order through import, editing, chapter content and export. Export also adds a body paragraph after a heading when needed, keeping scripture text outside the heading.This is a draft stacked on #305 because the import path is not on main yet. Please retarget this PR to
mainbefore merging #305, since merged branches are deleted automatically. No new migration or route is required. Refs #288; the web fix is eten-tech-foundation/fluent-web#432.Validation: all 607 tests passed, plus lint, formatting, typecheck, build and the docs check. An isolated PostgreSQL 16 smoke passed for immediate and delayed imports, saved edits, chapter content, export, empty titled verses, retries without overwrites and compatibility with legacy semantic-division records. Lint has three existing file-length warnings. The full pre-merge workflow does not run for a draft targeting the import branch.