Open
Conversation
Owner
There was a problem hiding this comment.
I'm confused by this: why are you opening the file? It should be sufficient just to do the get_input_string line below, as then LaTeX will drop the content in there instead of you needing to access the file.
So perhaps instead you want this to be if os.path.exists(os.path.join(localdir, 'authors.tex')):? Then if the files is present it will be used, but otherwise just the empty string from above will get in?
Owner
|
Thanks @mattpitkin - I'd noticed the authors option and been meaning to do something like that but hadn't found the time. I've left a few inline comments about the implementation that you'll need to address before I can merge, but it looks good in concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was missing authors in my output as I had a separate authors.tex file (you can do that in authorea by selecting customize). Also, my abstract already had the latex commands.