BAL devnet 3 support#35
Closed
jsign wants to merge 10 commits intoeth-act:mainfrom
Closed
Conversation
Signed-off-by: jsign <jsign.uy@gmail.com>
Signed-off-by: jsign <jsign.uy@gmail.com>
Collaborator
Author
|
Closing since I did #36 with a branch owned by this repo which I think is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has changes to support
bal-devnet-3branches for ELs.High-level overview of changes:
bal-devnet-3plus some cherry-picked commits -- these commits are mainly required fixes that happened inmainbut haven't been merged inbal-devnet-3yet.bal-devnet-3, which also means Reth-crates too. It also has some extra patch I made, mostly reg allowing BAL as output in fixture runs, so we can recreate BALs forExecutionPayloadconstruction as we do with Requests. Seeing if I can upstream this soon to remove the patch.NewPayloadRequestAmsterdamto support Amsterdam accordingly (i.e. newExecutionPayloadtypes, etc). Also, correct deserialization and validations for both ELs, etc.blocks.tar.gzfor CI with some blocks I pulled from the real BAL devnet 3 chain that went live just some days ago.Main goal here is:
I think for a bit, this PR will be kept as a draft. At some point, we can think it makes sense to merge, but that can make things quite unstable, so I'm not totally sure about that. We could use features to gate things, but it can get hairy -- I think we can discuss this eventually if it ends up being the main branch we use soon.