Conversation
Co-authored-by: Copilot <copilot@github.com>
jsign
commented
Apr 27, 2026
Comment on lines
+283
to
+284
| // TODO(Amsterdam): use actual BAL that should be received from parameter. | ||
| let block_access_list = Tx::try_from(alloy_rlp::encode(BlockAccessList::default())) |
Collaborator
Author
There was a problem hiding this comment.
The impl of this TODO would be the code happening in the BAL-devnet-3 branch/PR, since current EL dependencies doesn't have the logic to do this here now.
jsign
commented
Apr 27, 2026
| chain_spec.is_prague_active_at_timestamp(sealed_block.timestamp), | ||
| )?; | ||
|
|
||
| // TODO(Amsterdam): Add Amsterdam-specific validation. |
Collaborator
Author
There was a problem hiding this comment.
Ditto, since current EL branches don't have the code to check this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to push into
mainas much logic as possible from #36, so we keep the diff with that PR as small as possible.