Skip to content

fix(zisk): export CUDA_ARCH as CUDA_ARCHS env for cargo build #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qu0b wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(zisk): export CUDA_ARCH as CUDA_ARCHS env for cargo build #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docker/zisk/Dockerfile.cluster
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,11 @@ ARG CUDA
# Default to build for RTX 50 series
ARG CUDA_ARCH=sm_120

# Build binaries
RUN cargo build --release ${CUDA:+--features gpu}
# Strip the sm_ prefix and export as CUDA_ARCHS (plural, numeric) which is the
# env var proofman-starks-lib-c/build.rs reads to generate nvcc -gencode flags.
# See note in docker/zisk/Dockerfile.server for full rationale.
RUN CUDA_ARCHS="${CUDA_ARCH#sm_}" \
cargo build --release ${CUDA:+--features gpu}

FROM $RUNTIME_IMAGE AS runtime
FROM $RUNTIME_CUDA_IMAGE AS runtime_cuda
Expand Down
9 changes: 8 additions & 1 deletion docker/zisk/Dockerfile.server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@ ARG RUSTFLAGS
# Default to build for RTX 50 series
ARG CUDA_ARCH=sm_120

RUN cargo build --release --package ere-server --bin ere-server --features zisk${CUDA:+,cuda} \
# Strip the sm_ prefix and export as CUDA_ARCHS (plural, numeric) which is the
# env var proofman-starks-lib-c/build.rs reads to generate nvcc -gencode flags.
# Without this export, CUDA_ARCH is declared-but-unused and the build silently
# falls back to the committed sm_120 default in pil2-stark's CudaArch.mk,
# producing an image that fails on any non-sm_120 GPU with CUDA error 209
# (no kernel image is available for execution on the device).
RUN CUDA_ARCHS="${CUDA_ARCH#sm_}" \
cargo build --release --package ere-server --bin ere-server --features zisk${CUDA:+,cuda} \
&& mkdir bin && mv target/release/ere-server bin/ere-server \
&& cargo clean && rm -rf $CARGO_HOME/registry/

Expand Down
Loading