Custom imports based around wit files#18
Merged
Conversation
psilva261
force-pushed
the
psilva261/wit-imports
branch
from
c3e8a42 to
6500883
Compare
* Dotnet: swap out unmanaged code based imports with interface definions from WIT files * Go: adapt naming conventions * Update docs
psilva261
force-pushed
the
psilva261/wit-imports
branch
from
6500883 to
859c92f
Compare
Benchmark Results (65ec0fd)
|
Contributor
|
CC @marcinbugaj can you take a look? |
Benchmark Results (deb0861)
|
marcinbugaj
approved these changes
Feb 19, 2026
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a much cleaner way to handle imports. Also it's very much the definition language for the standardized WASI functions. So far I've seen only one issue where "unsigned" gets dropped but there's a simple workaround. Also it's still necessary to patch the WIT files to drop the wasip2 package names
The same approach is also used by componentize-dotnet (and therefore wit-bindgen) but the advantage is including it this way is more language neutral and it doesn't introduce another dependency