Remove using Reth stateless fork & other misc improvements#279
Merged
Conversation
- Bump versions of `reth-ethereum-primitives`, `reth-rpc-api`, and `reth-chainspec` to v2.1.0 in Cargo.toml. - Update `ef-tests` and `stateless` dependencies to new revisions. - Upgrade Alloy dependencies to version 2.0. - Refactor `witness-generator` to simplify feature flags for `reth-ethereum-primitives`. - Enhance `eest_generator.rs` by introducing helper functions for loading and filtering tests, improving code readability and maintainability. - Modify `raw_input_generator.rs` to streamline the reading of chain configuration. - Update `rpc_generator.rs` to include optional parameters in API calls for better flexibility.
…date documentation
…dating documentation
jsign
commented
Apr 23, 2026
|
|
||
| ```bash | ||
| cargo run -p witness-generator-cli --release -- tests --include 10M --include Prague | ||
| EF_TEST_TRIE=default RUST_MIN_STACK=16388608 RUST_LOG=info RAYON_NUM_THREADS=8 cargo run -p witness-generator-cli --release -- tests |
Collaborator
Author
There was a problem hiding this comment.
Clarifying a bit some env vars that paradigmxyz/stateless still needs. Not nice but at least I can remove now using a fork.
With Kev we are trying to see if we can fill execution witness during EEST benchmark generation -- when that day comes, we can remove basically the whole witness-generator-cli stuff for EEST that requires stateless for "out of band" execution witness generation.
…nload handling in benchmark runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the witness generation stack and improves EEST fixture generation so large fixture sets can be generated more reliably.
Changes
v2.1.0, Alloy dependencies to2.0, and updatesef-tests/statelessto the newer upstream revision.jsign/statelesspatch override.generate_to_pathimplementation that streams fixtures to disk instead of retaining every generated fixture in memory.block-encoding-lengthfixture generationere-guestsinstead of maintaining a local hardcoded target.