feat: unified predeploys source of truth by 0xniha · Pull Request #19847 · ethereum-optimism/optimism

0xniha · 2026-03-31T23:11:05Z

Description
Add unified predeploys source of truth

Closes #19260

…nc issues

0xniha · 2026-03-31T23:12:42Z

/ci authorize 2814901

0xniha · 2026-04-01T13:57:34Z

/ci authorize 7cadd7e

codecov · 2026-04-01T14:13:07Z

Codecov Report

❌ Patch coverage is 97.76119% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.5%. Comparing base (63509a6) to head (f98e31b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ges/contracts-bedrock/src/libraries/Predeploys.sol	97.2%	2 Missing ⚠️
...-bedrock/src/libraries/L2ContractsManagerUtils.sol	83.3%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #19847     +/-   ##
==========================================
+ Coverage     76.3%    82.5%   +6.2%     
==========================================
  Files          186      131     -55     
  Lines        10691     6670   -4021     
==========================================
- Hits          8167     5509   -2658     
+ Misses        2380     1161   -1219     
+ Partials       144        0    -144

Flag	Coverage Δ
cannon-go-tests-64	`?`
contracts-bedrock-tests	`82.5% <97.7%> (+0.1%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...es/contracts-bedrock/src/L2/L2ContractsManager.sol	`96.6% <100.0%> (+<0.1%)`	⬆️
...-bedrock/src/libraries/L2ContractsManagerUtils.sol	`93.6% <83.3%> (-1.6%)`	⬇️
...ges/contracts-bedrock/src/libraries/Predeploys.sol	`96.4% <97.2%> (-2.3%)`	⬇️

... and 56 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

0xniha · 2026-04-01T18:05:19Z

/ci authorize cdcff62

…tive registry

A Predeploy name can always be derived from the Predeploy registry, no matter it has a variant.

… from the Predeploy Registry and removes _interopCodeDiffer

…scripts

…loys-sot

maurelian · 2026-04-27T19:15:16Z

It won't work to rebuild the karst bundle in this PR, that's why the check-nut-locks job is failing.

maurelian · 2026-04-27T19:22:55Z

won't work to rebuild the karst bundle in this PR.

We can just wait and rebuild it right before the release.

Restored here

…ecord refactor: replace implementations struct by implementations record array

Conflicts: - packages/contracts-bedrock/scripts/libraries/UpgradeUtils.sol - packages/contracts-bedrock/scripts/upgrade/GenerateNUTBundle.s.sol - packages/contracts-bedrock/snapshots/semver-lock.json - packages/contracts-bedrock/snapshots/upgrades/current-upgrade-bundle.json - packages/contracts-bedrock/test/scripts/GenerateNUTBundle.t.sol

0xniha added 2 commits March 30, 2026 11:15

refactor: gather all config from generate nut bundle script to fix sy…

4125cc6

…nc issues

feat: unified predeploys source of truth

2814901

0xniha self-assigned this Mar 31, 2026

fix: include deprecated predeploys deployments

7cadd7e

maurelian reviewed Apr 1, 2026

View reviewed changes

Comment thread packages/contracts-bedrock/src/L2/L2ContractsManager.sol

maurelian reviewed Apr 1, 2026

View reviewed changes

fix: proxy all predeploys

cdcff62

0xiamflux reviewed Apr 2, 2026

View reviewed changes

Comment thread packages/contracts-bedrock/scripts/upgrade/GenerateNUTBundle.s.sol Outdated

0xniha added 2 commits April 2, 2026 10:22

refactor: use lib string to cmp strings

aa1db6e

fix: argument order in ImplementationConfig

22d651f

0xiamflux reviewed Apr 2, 2026

View reviewed changes

maurelian reviewed Apr 2, 2026

View reviewed changes

Comment thread packages/contracts-bedrock/test/L2/fork/L2ForkUpgrade.t.sol

0xniha added 10 commits April 2, 2026 11:11

refactor: add useInterop to L2CM tests

53e72b4

fix: remove skipStandardDeploy natspec

b18175a

test: add cgt and interop tests for l2genesis fork upgrade

4e15616

fix: set correct name for l1 block attributes

bfc3b7e

feat: add getUpgradeableRecords to predeploys lib

6aabdb0

feat: add L2CM feature to ci matrix

cab510f

fix: deploy config comment

27187a9

Merge branch 'develop' into feat/l2cm-predeploys-sot

7e07b83

fix: remove l2cm from ci matrix

65e137f

fix: update L2CM version

7f71863

0xniha marked this pull request as ready for review April 6, 2026 15:28

0xniha requested review from a team and tynes April 6, 2026 15:28

fix: replace sysfeature gate for isCGT and isInterop booleans

a6d05c4

0xniha added 2 commits April 21, 2026 17:31

fix: remove gas profiling comments

32c9f84

fix: rename buildImplementationDeploymentConfigs without underscore

97643e4

0xOneTony mentioned this pull request Apr 22, 2026

[L2CM] Refactor to establish a source of truth for predeploys and ensure parity between L2Genesis and L2CM upgrades #19260

Open

Merge branch 'develop' into feat/l2cm-predeploys-sot

dd2cd0a

0xniha requested a review from a team as a code owner April 22, 2026 14:55

0xniha and others added 8 commits April 22, 2026 12:29

fix: remove claude docs

4abfa1b

feat: replace notProxied hardcoded logic for queries to the authorita…

3a1f57f

…tive registry

refactor: remove hardcoded address from getName.

788bb5f

A Predeploy name can always be derived from the Predeploy registry, no matter it has a variant.

test: add getName test for proxy variants

834af9c

test: updates helper function _customGasTokenCodeDiffer to be derived…

9127107

… from the Predeploy Registry and removes _interopCodeDiffer

fix: add skipIfUnoptimized in L2GenesisForkUpgrade test

c4f2f72

fix: fork toml

5290632

docs: add optimized compilation need for bundle execution comment on …

62c8288

…scripts

0xiamflux mentioned this pull request Apr 23, 2026

feat: L2CM authoritative registry #20280

Closed

0xiamflux and others added 7 commits April 23, 2026 08:52

Merge branch 'feat/l2cm-authoritative-registry' into feat/l2cm-predep…

bd449f7

…loys-sot

refactor: replace implementations struct by implementations record array

c53e463

docs: update natspec

fa41474

test: check impl record length and values

cfedb58

refactor: move helper findImpl into utils lib

ea6144a

chore: dev note for places to update when adding a new predeploy

c5ebf8f

chore: just pr

1697f14

maurelian reviewed Apr 27, 2026

View reviewed changes

0xiamflux added 7 commits April 28, 2026 10:54

Merge pull request #20290 from ethereum-optimism/refactor/l2cm-impl-r…

f296983

…ecord refactor: replace implementations struct by implementations record array

chore: restore op-core nuts files to develop state

85a11bc

chore: add L2CM to code exemptions to deal with bytecode size limits

fcce665

chore: adjust gas limits

0ee96bb

chore: just pr

b2048a6

chore: just pr

f98e31b

Conversation

0xniha commented Mar 31, 2026

Uh oh!

0xniha commented Mar 31, 2026

Uh oh!

0xniha commented Apr 1, 2026

Uh oh!

codecov Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xniha commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maurelian Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

maurelian Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

maurelian Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

0xiamflux Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 1, 2026 •

edited

Loading