fix(op-reth): detect reth storage layout in InitializationJob#20396
Open
dhyaniarun1993 wants to merge 3 commits intoethereum-optimism:developfrom
Open
fix(op-reth): detect reth storage layout in InitializationJob#20396dhyaniarun1993 wants to merge 3 commits intoethereum-optimism:developfrom
dhyaniarun1993 wants to merge 3 commits intoethereum-optimism:developfrom
Conversation
dhyaniarun1993
force-pushed
the
fix/proofs-init-v1-storage-panic
branch
from
2e5c927 to
53ac22a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running op-reth proofs init on a production OP Mainnet node (synced before reth introduced v2 packed storage) panics with:
index out of bounds: the len is 1 but the index is 32
The panic is in PackedStoredNibbles::from_compact, which always reads buf[32] as the nibble count. On v1-storage nodes, AccountsTrie keys are variable-length (1 nibble per byte, 1–64 bytes). A 1-nibble path is 1 byte — indexing buf[32] panics.
Tests
Tested v1 in op mainnet
v2 is being tested in e2e
Additional context
NA
Metadata