Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trezor support was previously added in #1089 but reverted in #1100. This implementation aims to set us up to add more wallet types in the future, while maintaining backwards compatibility with the existing syntaxes for now
This is dependent on using the latest eip712sign release, and a trezor firmware version of at least v2.9.1
Manual Testing Checklist
Ledger (Existing - Should Not Break)
just sign- default ledger signingHD_PATH=1 just sign- custom HD pathjust sign council- nested safeSIMULATE_WITHOUT_LEDGER=1 just simulate- shows deprecation warningTrezor (New)
WALLET_TYPE=trezor just sign- basic signingHD_PATH=1 WALLET_TYPE=trezor just sign- custom HD pathWALLET_TYPE=trezor just sign foundation- nested safeKeystore
WALLET_TYPE=keystore just sign- new syntaxUSE_KEYSTORE=1 just sign- old syntax shows warningSimulation & Errors
SIMULATE_WITHOUT_WALLET=1 just simulate- no hardware neededWALLET_TYPE=invalid just sign- shows clear error with valid options