upgrade foundry deps to v1.4.3#1358
Open
AmadiMichael wants to merge 6 commits intomainfrom
Open
Conversation
mds1
reviewed
Jan 29, 2026
Contributor
There was a problem hiding this comment.
We should explain what this file is in the PR description. Also, do we still need the gitmodules file with this, or should it be deleted?
mds1
reviewed
Jan 29, 2026
| gas_limit = "18446744073709551615" # max allowable value, which is max uint64 | ||
| ffi = true # Enable FFI for reading lib/superchain-registry files in scripts SignFromJson.s.sol, NestedSignFromJson.s.sol within tasks | ||
| no_match_coverage = 'src/template/boilerplate/|script/|src/JsonTxBuilderBase.sol|test' | ||
| script_execution_protection = false |
Contributor
There was a problem hiding this comment.
This is also a good thing to explain or link to docs about for reviewers in the PR description
mds1
reviewed
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Why do we need to add this file, can it be removed?
mds1
reviewed
Jan 29, 2026
Comment on lines
+206
to
+207
| Simulation.StorageOverride[] memory combined = new Simulation | ||
| .StorageOverride[](defaultOverrides_[j].overrides.length + userDefinedOverride_.overrides.length); |
Contributor
There was a problem hiding this comment.
This seems like a weird formatter split, is this a bug or is there a way we can fix it?
Contributor
Author
There was a problem hiding this comment.
probably the work of the new formatter
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…n-ops into amadi/foundry-1.4.3-upgrade
alcueca
reviewed
Feb 2, 2026
alcueca
reviewed
Feb 2, 2026
alcueca
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade foundry dependencies to 1.4.3.
foundry.lock, tracks exact revisions for all dependencies inlib/.Proposal PR: ethereum-optimism/design-docs#363