-
Notifications
You must be signed in to change notification settings - Fork 128
Deputy pause key rotation tasks for eth and sep #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JosepBove
wants to merge
2
commits into
main
Choose a base branch
from
deputy-pause-key-rotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # 052-deputy-pause-key-rotation | ||
|
|
||
| Status: READY TO SIGN | ||
|
|
||
| ## Objective | ||
|
|
||
| Rotates the `DeputyPauseModule` Deputy EOA from `0x352f1defb49718e7ea411687e850aa8d6299f7ac` to `0x2fA150379bF32b6d79Eeb4ff9bD280E76049a87c`. | ||
| To achieve this, we will use the `setDeputy` function of the `DeputyPauseModule` contract deployed at `0x126a736B18E0a64fBA19D421647A530E327E112C`. | ||
|
|
||
| ## Simulation | ||
|
|
||
| Please see the "Simulating and Verifying the Transaction" instructions in [SINGLE.md](../../../SINGLE.md). | ||
| When simulating, ensure the logs say `Using script /your/path/to/superchain-ops/src/template/DeputyPauseKeyRotationTemplate.sol`. | ||
| This ensures all safety checks are run. If the default `SignFromJson.s.sol` script is shown (without the full path), something is wrong and the safety checks will not run. | ||
|
|
||
| ## State Validation | ||
|
|
||
| Please see the instructions for [validation](./VALIDATION.md). | ||
|
|
||
| ## Execution | ||
|
|
||
| Rotates the `DeputyPauseModule` Deputy EOA from `0x352f1defb49718e7ea411687e850aa8d6299f7ac` to `0x2fA150379bF32b6d79Eeb4ff9bD280E76049a87c` in the [DeputyPauseModule](https://etherscan.io/address/0x126a736B18E0a64fBA19D421647A530E327E112C#code). | ||
|
|
||
| ## Signing and execution | ||
|
|
||
| This task has to be signed by the [FoundationOperationsSafe](https://etherscan.io/address/0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Validation | ||
|
|
||
| This document can be used to validate the state diff resulting from the execution of the upgrade | ||
| transaction. | ||
|
|
||
| For each contract listed in the state diff, please verify that no contracts or state changes shown in the Tenderly diff are missing from this document. Additionally, please verify that for each contract: | ||
|
|
||
| - The following state changes (and none others) are made to that contract. This validates that no unexpected state changes occur. | ||
| - All addresses (in section headers and storage values) match the provided name, using the Etherscan and Superchain Registry links provided. This validates the bytecode deployed at the addresses contains the correct logic. | ||
| - All key values match the semantic meaning provided, which can be validated using the storage layout links provided. | ||
|
|
||
| ## Expected Domain and Message Hashes | ||
|
|
||
| > [!CAUTION] | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Optimism Foundation | ||
| > | ||
| > Domain Hash: 0x2e5ad244d335c45fbace4ebd1736b0fad81b01591a2819baedad311ead5bce76 | ||
| > Message Hash: 0xbb9508edc2cb54922dfdbd999b50b95622aa8be4475159ceb3d4a6306241f192 | ||
|
|
||
| ## State Overrides | ||
|
|
||
| The following state overrides should be seen: | ||
|
|
||
| ### `0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A` (The Optimism Foundation Operations Safe) | ||
|
|
||
| Links: | ||
|
|
||
| - [Etherscan](https://etherscan.io/address/0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A) | ||
|
|
||
| Enables the simulation by setting the threshold to 1: | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000004` <br/> | ||
| **Value:** `0x0000000000000000000000000000000000000000000000000000000000000001` | ||
|
|
||
| ## State Changes | ||
|
|
||
| ### `0x9ba6e03d8b90de867373db8cf1a58d2f7f006b3a` (Foundation Operations Safe) | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000005` | ||
| - **Decoded Kind:** `uint256` | ||
| - **Before:** `118` | ||
| - **After:** `119` | ||
| - **Summary:** nonce | ||
| - **Detail:** | ||
|
|
||
| This updates the nonce of the Foundation Operations Safe. | ||
|
|
||
| --- | ||
|
|
||
| ### `0x126a736b18e0a64fba19d421647a530e327e112c` (DeputyPauseModule) | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000002` | ||
| - **Before:** `0x000000000000000000000000352f1defb49718e7ea411687e850aa8d6299f7ac` | ||
| - **After:** `0x0000000000000000000000002fa150379bf32b6d79eeb4ff9bd280e76049a87c` | ||
| - **Summary:** | ||
| - **Detail:** | ||
|
|
||
| This updates the previous deputy `0x352f1defB49718e7Ea411687E850aA8d6299F7aC` to `0x2fA150379bF32b6d79Eeb4ff9bD280E76049a87c`. | ||
|
JosepBove marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| l2chains = [{name = "OP Mainnet", chainId = 10}] | ||
| templateName = "DeputyPauseKeyRotationTemplate" | ||
|
|
||
| newDeputy = "0x2fA150379bF32b6d79Eeb4ff9bD280E76049a87c" | ||
|
|
||
| newDeputySignature = "0x9f1c36e3cfcc19c4e2349600477d1cd782856d62c520b4f6295f7922fe333b91772a4949015fe38ce61f34353967d0b2c33126793b7609d4227189fa828db2271c" | ||
|
JosepBove marked this conversation as resolved.
|
||
|
|
||
| [stateOverrides] | ||
| # Nonce override for simulation (storage slot 0x5 is the nonce) | ||
| 0x9BA6e03D8B90dE867373Db8cF1A58d2F7F006b3A = [ | ||
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 118} | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # 074-deputy-pause-key-rotation | ||
|
|
||
| Status: READY TO SIGN | ||
|
|
||
| ## Objective | ||
|
|
||
| Rotates the `DeputyPauseModule` Deputy EOA from `0x6A07d585eddBa8F9A4E17587F4Ea5378De1c3bAc` to `0x8D2AAe4009418Ef6D83F1F2c90D4dAc3cE2b5D4f`. | ||
| To achieve this, we will use the `setDeputy` function of the `DeputyPauseModule` contract deployed at `0xc6f7C07047ba37116A3FdC444Afb5018f6Df5758`. | ||
|
|
||
| ## Simulation | ||
|
|
||
| Please see the "Simulating and Verifying the Transaction" instructions in [SINGLE.md](../../../SINGLE.md). | ||
| When simulating, ensure the logs say `Using script /your/path/to/superchain-ops/src/template/DeputyPauseKeyRotationTemplate.sol`. | ||
| This ensures all safety checks are run. If the default `SignFromJson.s.sol` script is shown (without the full path), something is wrong and the safety checks will not run. | ||
|
|
||
| ## State Validation | ||
|
|
||
| Please see the instructions for [validation](./VALIDATION.md). | ||
|
|
||
| ## Execution | ||
|
|
||
| Rotates the `DeputyPauseModule` Deputy EOA from `0x6A07d585eddBa8F9A4E17587F4Ea5378De1c3bAc` to `0x8D2AAe4009418Ef6D83F1F2c90D4dAc3cE2b5D4f` in the [DeputyPauseModule](https://sepolia.etherscan.io/address/0xc6f7C07047ba37116A3FdC444Afb5018f6Df5758#code). | ||
|
|
||
| ## Signing and execution | ||
|
|
||
| This task has to be signed by the [FakeFoundationOperationsSafe](https://sepolia.etherscan.io/address/0x837DE453AD5F21E89771e3c06239d8236c0EFd5E). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Validation | ||
|
|
||
| This document can be used to validate the state diff resulting from the execution of the upgrade | ||
| transaction. | ||
|
|
||
| For each contract listed in the state diff, please verify that no contracts or state changes shown in the Tenderly diff are missing from this document. Additionally, please verify that for each contract: | ||
|
|
||
| - The following state changes (and none others) are made to that contract. This validates that no unexpected state changes occur. | ||
| - All addresses (in section headers and storage values) match the provided name, using the Etherscan and Superchain Registry links provided. This validates the bytecode deployed at the addresses contains the correct logic. | ||
| - All key values match the semantic meaning provided, which can be validated using the storage layout links provided. | ||
|
|
||
| ## Expected Domain and Message Hashes | ||
|
|
||
| > [!CAUTION] | ||
| > Before signing, ensure the below hashes match what is on your ledger. | ||
| > | ||
| > ### Optimism Foundation | ||
| > | ||
| > Domain Hash: 0xe84ad8db37faa1651b140c17c70e4c48eaa47a635e0db097ddf4ce1cc14b9ecb | ||
| > Message Hash: 0xafab6e4cffa2647bb9f26cf85d2cb60c7ad6b9a2d4904abd7ac0f0af4279958a | ||
|
|
||
| ## State Overrides | ||
|
|
||
| The following state overrides should be seen: | ||
|
|
||
| ### `0x837DE453AD5F21E89771e3c06239d8236c0EFd5E` (The Optimism Foundation Operations Safe) | ||
|
|
||
| Links: | ||
|
|
||
| - [Etherscan](https://sepolia.etherscan.io/address/0x837DE453AD5F21E89771e3c06239d8236c0EFd5E) | ||
|
|
||
| Enables the simulation by setting the threshold to 1: | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000004` <br/> | ||
| **Value:** `0x0000000000000000000000000000000000000000000000000000000000000001` | ||
|
|
||
| ## State Changes | ||
|
|
||
| ### `0x837de453ad5f21e89771e3c06239d8236c0efd5e` (Foundation Operations Safe) | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000005` | ||
| - **Decoded Kind:** `uint256` | ||
| - **Before:** `11` | ||
| - **After:** `12` | ||
| - **Summary:** nonce | ||
| - **Detail:** | ||
|
|
||
| This updates the nonce of the Foundation Operations Safe. | ||
|
|
||
| --- | ||
|
|
||
| ### `0xc6f7c07047ba37116a3fdc444afb5018f6df5758` (DeputyPauseModule) | ||
|
|
||
| - **Key:** `0x0000000000000000000000000000000000000000000000000000000000000002` | ||
| - **Before:** `0x0000000000000000000000006a07d585eddba8f9a4e17587f4ea5378de1c3bac` | ||
| - **After:** `0x0000000000000000000000008d2aae4009418ef6d83f1f2c90d4dac3ce2b5d4f` | ||
| - **Summary:** | ||
| - **Detail:** | ||
|
|
||
| This updates the previous deputy `0x6A07d585eddBa8F9A4E17587F4Ea5378De1c3bAc` to `0x8D2AAe4009418Ef6D83F1F2c90D4dAc3cE2b5D4f`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| l2chains = [{name = "OP Sepolia Testnet", chainId = 11155420}] | ||
| templateName = "DeputyPauseKeyRotationTemplate" | ||
|
|
||
| newDeputy = "0x8D2AAe4009418Ef6D83F1F2c90D4dAc3cE2b5D4f" | ||
|
|
||
| newDeputySignature = "0x3d3d1206bfb51e9d6db5ab1d474619cffa44907b5f2055966fa26cc85c6783f45f78cdfb0300f89763e29357c9f077f1ae83cc83a2711f51f1b4c84478287e8e1c" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just for best practice we should separate this PRs in 2 PRs one for mainnet and one for sepolia in case we catch something on the sepolia would be nice to identify an separate PRs. |
||
|
|
||
| [stateOverrides] | ||
| # Nonce override for simulation (storage slot 0x5 is the nonce) | ||
| 0x837DE453AD5F21E89771e3c06239d8236c0EFd5E = [ | ||
| {key = "0x0000000000000000000000000000000000000000000000000000000000000005", value = 11} | ||
| ] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.