feat(v700): bump OPCM to v7.1.17 and add ZK_DISPUTE_GAME slot#1410
Open
stevennevins wants to merge 3 commits intomainfrom
Open
feat(v700): bump OPCM to v7.1.17 and add ZK_DISPUTE_GAME slot#1410stevennevins wants to merge 3 commits intomainfrom
stevennevins wants to merge 3 commits intomainfrom
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
ajsutton
approved these changes
Apr 30, 2026
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
LGTM - just the one note about future proofing.
| if (gt == SUPER_CANNON_KONA) { | ||
| return address(disputeGameFactory.gameImpls(GameType.wrap(CANNON_KONA))) != address(0); | ||
| } | ||
| if (gt == ZK_DISPUTE_GAME) return false; |
Contributor
There was a problem hiding this comment.
I know this is strictly never deployed now but shouldn't we actually check the gameImpls anyway? That way when this is inevitably copied to create the template for V8 where ZK is deployed somewhere it will just work instead of being a footgun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the OPCM v700 upgrade fixture to use the new devnet OPCM at
0x15c65ee282777e4a2856fdf26d33ee4d5bab30c4(v7.1.17), which now requires a 7thZK_DISPUTE_GAME(raw value 10) entry indisputeGameConfigsperOPContractsManagerV2._assertValidFullConfig. The template now builds a length-7 config array with the ZK slot disabled (matches migrator behavior of zeroing the ZK impl), bumps the version assertion to7.1.17, and drops the now-fixedSCDG-SHAPEvalidation error fromexpectedValidationErrors.SuperRootUpgradeTest(test_load_data+test_upgrade_sepolia) passes against a Sepolia fork.Additional context
The ZK slot stays disabled because the new OPCM only allows it when
DevFeatures.ZK_DISPUTE_GAMEis enabled, which is not set on this devnet bitmap.