Update EIP-8130: prevent cross-sender payer signature replay#11591
Open
pochenai wants to merge 1 commit intoethereum:masterfrom
Open
Update EIP-8130: prevent cross-sender payer signature replay#11591pochenai wants to merge 1 commit intoethereum:masterfrom
pochenai wants to merge 1 commit intoethereum:masterfrom
Conversation
The payer signature hash includes a `from` field, but the spec did not say what to put there in the EOA path where `from` is empty in the wire format. If `from` were encoded as empty, two different EOAs with otherwise identical tx data would produce identical payer hashes, letting a second EOA reuse a payer signature meant for the first and drain the payer's gas deposit. Require substituting the recovered sender address into the `from` position before hashing, and document the threat in Security Considerations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
c-update
Collaborator
File
|
Author
|
It's a critical issue, please review when you are available @chunter-cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payer signature hash includes a
fromfield, but the spec did not say what to put there in the EOA path wherefromis empty in the wire format. Iffromwere encoded as empty, two different EOAs with otherwise identical tx data would produce identical payer hashes, letting a second EOA reuse a payer signature meant for the first and drain the payer's gas deposit. Require substituting the recovered sender address into thefromposition before hashing, and document the threat in Security Considerations.ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: