Fix regular expression for compactability - #114
Open
IjayAbby wants to merge 3 commits into
Open
Conversation
IjayAbby
changed the title
IjayAbby
marked this pull request as ready for review
October 29, 2024 19:10
Author
|
Been doing more background talks with @SamWilsn on discord and this is the last point to note and I quote him **I put up my branch. Please keep in mind that it won't work until #478 is fixed, but it'll give you an idea of how the API will look. Not to repeat myself too much, but you had an excellent idea to use the markdown source to determine what type of link we're dealing with! The new function of most interest to you will be: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected issue was fixed using the explanation below
Error
Reports common mistakes when referencing other proposals, like omitting the hyphen (EIP1234), or replacing it with a space (EIP 1234).
The Fix
For consistency, all proposals should be referenced in the same way.
Interfaces and contract names should be enclosed in backticks to avoid this error: EIP-1234.
These are the backwards compatibility concerns for the EIP-1234.