fix: detect HTML comments in inline HTML nodes - #140
Closed
Kubudak90 wants to merge 2 commits into
Closed
Conversation
added 2 commits
April 7, 2026 16:16
The HtmlComments lint only checked NodeValue::HtmlBlock but not NodeValue::HtmlInline. This meant inline HTML comments like: text <!-- comment --> more text were not detected, while block comments like: <!-- comment --> were correctly flagged. This fix adds handling for NodeValue::HtmlInline to ensure all HTML comments are detected regardless of their context.
Add explicit '_ lifetime annotations to the span_utf8 function in the LevelExt trait and its implementation. This fixes Rust compiler warnings about elided lifetimes having multiple possible interpretations.
Author
|
Closing as duplicate of #141, which includes the same fix plus regression tests. |
Kubudak90
pushed a commit
to Kubudak90/eipw
that referenced
this pull request
Apr 20, 2026
The HtmlComments lint previously only checked NodeValue::HtmlBlock, missing HTML comments embedded within inline HTML like: This is the <!-- motivation -->. Now also checks NodeValue::HtmlInline so inline HTML comments are correctly flagged. Fixes ethereum#140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HtmlComments lint only checked NodeValue::HtmlBlock but not NodeValue::HtmlInline. This meant inline HTML comments were not detected while block comments were correctly flagged.
This PR adds handling for NodeValue::HtmlInline to ensure all HTML comments are detected regardless of their context.
Changes: Added one line to handle NodeValue::HtmlInline in the match statement
All existing tests pass with this change.