fix: skip regex checks on autolink URLs - #145
Closed
Kubudak90 wants to merge 1 commit into
Closed
Conversation
Fixes ethereum#91. Autolinks like \u003chttps://example.com/eip7002\u003e were incorrectly checked against regex patterns, causing false positives when URLs contained prohibited patterns. Root cause: the visitor traverses all text nodes, including autolink URL text, which shouldn't be checked. Solution: use a link URL stack to track when we're inside a link. When enter_text sees text matching the top URL on the stack, it's an autolink and we skip the pattern check. This correctly handles: - Autolinks: URL text is not checked - Regular links: [text](url) - link text is still checked - Nested links: stack handles nesting correctly
Author
|
Closing in favor of #152 which has the same fix with a cleaner commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91.
Autolinks like \u003chttps://example.com/eip7002\u003e were incorrectly checked against regex patterns, causing false positives when URLs contained prohibited patterns.
Root Cause
The visitor traverses all text nodes, including autolink URL text, which shouldn't be checked against regex patterns.
Solution
Use a link URL stack to track when we're inside a link:
This correctly handles:
Changes
All existing tests pass.