fix: resolve relative paths when cwd differs from EIPs repo root - #154
Closed
Kubudak90 wants to merge 1 commit into
Closed
fix: resolve relative paths when cwd differs from EIPs repo root#154Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
When linting files from a working directory different than the root of the EIPs repository, the preamble-requires-status check would fail with ENOENT errors because it tried to find required EIPs at relative paths like ./EIPS/eip-xxxx.md instead of the correct absolute paths. This fix normalizes relative paths by joining them with the current working directory, ensuring required EIPs are found regardless of where the linter is invoked from. Fixes ethereum#12
Kubudak90
force-pushed
the
fix/issue-12-cwd-relative-paths
branch
from
April 14, 2026 19:54
9f89249 to
ff9deca
Compare
Author
|
Closing in favor of #153 which takes a more comprehensive approach by normalizing the source path early, including WASM support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linting files from a working directory different than the root of the EIPs repository, the
preamble-requires-statuscheck would fail with ENOENT errors because it tried to find required EIPs at relative paths like./EIPS/eip-xxxx.mdinstead of the correct absolute paths.This fix normalizes relative paths by joining them with the current working directory, ensuring required EIPs are found regardless of where the linter is invoked from.
Includes a regression test that reproduces the issue.
Fixes #12