fix: prevent panic in markdown-json-cite with non-ASCII input - #162
Open
Kubudak90 wants to merge 1 commit into
Open
fix: prevent panic in markdown-json-cite with non-ASCII input#162Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
…ations Fixes panic on non-ASCII characters in csl-json blocks. Closes ethereum#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
Bug: When a CSL-JSON citation block contains non-ASCII characters (e.g., "Mazières"), panics with:
Root cause: In , the annotation span was computed using , which returns the byte length of the UTF-8 string. However, expects character counts for its ranges. Non-ASCII characters like take 2 bytes in UTF-8, causing the span end to exceed the source length in characters.
Fix: Replace with so the span uses character count instead of byte length.
Testing: