Skip to content

feat(spec-specs, tests): align EIP-8037 with forks/amsterdam GasCosts refactor#2737

Merged
spencer-tb merged 1 commit intoethereum:eips/amsterdam/eip-8037from
spencer-tb:pr/eip-8037-amsterdam-compat
Apr 21, 2026
Merged

feat(spec-specs, tests): align EIP-8037 with forks/amsterdam GasCosts refactor#2737
spencer-tb merged 1 commit intoethereum:eips/amsterdam/eip-8037from
spencer-tb:pr/eip-8037-amsterdam-compat

Conversation

@spencer-tb
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb commented Apr 21, 2026

Summary

Adapts the EIP-8037 branch to forks/amsterdam's module level to GasCosts refactor (#2396). Files touched by EIP-8037 switch from the old module-level GAS_X constants to GasCosts.X attributes; GAS_STORAGE_UPDATE maps to GasCosts.COLD_STORAGE_WRITE.

@spencer-tb spencer-tb force-pushed the eips/amsterdam/eip-8037 branch from de71eca to aedeebd Compare April 21, 2026 01:09
@spencer-tb spencer-tb closed this Apr 21, 2026
@spencer-tb spencer-tb deleted the pr/eip-8037-amsterdam-compat branch April 21, 2026 01:10
@spencer-tb spencer-tb restored the pr/eip-8037-amsterdam-compat branch April 21, 2026 01:11
@spencer-tb spencer-tb reopened this Apr 21, 2026
@spencer-tb spencer-tb force-pushed the pr/eip-8037-amsterdam-compat branch from fb5375b to e956154 Compare April 21, 2026 01:18
@spencer-tb spencer-tb changed the title fix(rebase): align EIP-8037 with forks/amsterdam GasCosts refactor feat(spec-specs, tests): align EIP-8037 with forks/amsterdam GasCosts refactor Apr 21, 2026
@spencer-tb spencer-tb added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) labels Apr 21, 2026
@spencer-tb spencer-tb force-pushed the pr/eip-8037-amsterdam-compat branch from e956154 to 5c359e3 Compare April 21, 2026 01:21
@spencer-tb spencer-tb force-pushed the eips/amsterdam/eip-8037 branch from de71eca to f2049fb Compare April 21, 2026 01:25
@spencer-tb spencer-tb force-pushed the pr/eip-8037-amsterdam-compat branch 3 times, most recently from 0f8464c to 76a0cdc Compare April 21, 2026 01:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-8037@f2049fb). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-8037    #2737   +/-   ##
==========================================================
  Coverage                           ?   86.49%           
==========================================================
  Files                              ?      599           
  Lines                              ?    37765           
  Branches                           ?     3804           
==========================================================
  Hits                               ?    32666           
  Misses                             ?     4531           
  Partials                           ?      568           
Flag Coverage Δ
unittests 86.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adapt EIP-8037 to forks/amsterdam's module-level-to-GasCosts refactor:
rename GAS_X → GasCosts.X in 8037 files, with remappings:
  GAS_STORAGE_UPDATE   → GasCosts.COLD_STORAGE_WRITE
  GAS_KECCAK256_PER_WORD → GasCosts.OPCODE_KECCACK256_PER_WORD
  GAS_SELF_DESTRUCT    → GasCosts.OPCODE_SELFDESTRUCT_BASE
  GAS_CREATE           → GasCosts.OPCODE_CREATE_BASE
  GAS_MEMORY           → GasCosts.MEMORY_PER_WORD

Tests: 977 pass.
@spencer-tb spencer-tb force-pushed the pr/eip-8037-amsterdam-compat branch from 76a0cdc to f83131f Compare April 21, 2026 02:16
@spencer-tb spencer-tb merged commit c3dee65 into ethereum:eips/amsterdam/eip-8037 Apr 21, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant