feat(spec-specs,tests): apply transfer log costs to EIP-2780#2752
Open
gurukamath wants to merge 1 commit intoethereum:eips/amsterdam/eip-2780from
Open
feat(spec-specs,tests): apply transfer log costs to EIP-2780#2752gurukamath wants to merge 1 commit intoethereum:eips/amsterdam/eip-2780from
gurukamath wants to merge 1 commit intoethereum:eips/amsterdam/eip-2780from
Conversation
Aligns the EIP-2780 implementation and tests with the revision that introduces TRANSFER_LOG_COST = 1,756 for non-self value transfers, prices value-carrying CALL as a self-call when caller == to, and treats CALLCODE's value transfer as always self (no log, single STATE_UPDATE). SELFDESTRUCT now charges TRANSFER_LOG_COST when it moves non-zero balance to a different beneficiary. Temporarily ignores tests/ported_static during fill while the ported static fixtures are updated for the new gas schedule.
gurukamath
changed the base branch from
forks/amsterdam
to
eips/amsterdam/eip-2780
gurukamath
changed the title
danceratopz
added
A-spec-specs
danceratopz
changed the title
danceratopz
approved these changes
Apr 30, 2026
Member
There was a problem hiding this comment.
Thanks @gurukamath, this looks great. Good call to ignore ./tests/ported_static for now. We should only expend our energy here once the other gas repricings have been merged.
During review I spotted a few gaps regarding EIP-7708 in EIP-2780, I'd be grateful if you had time to provide feedback 🙏 ethereum/EIPs#11586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Aligns the EIP-2780 implementation and tests with the revision that introduces TRANSFER_LOG_COST = 1,756 for non-self value transfers, prices value-carrying CALL as a self-call when caller == to, and treats CALLCODE's value transfer as always self (no log, single STATE_UPDATE). SELFDESTRUCT now charges TRANSFER_LOG_COST when it moves non-zero balance to a different beneficiary.
Temporarily ignores tests/ported_static during fill while the ported static fixtures are updated for the new gas schedule. Fix for the broken ported static tests are in scope for a later PR
🔗 Related Issues or PRs
Issue #1940
✅ Checklist
just statictype(scope):.Cute Animal Picture