Chore/ci security coverage hooks reproducible builds - #454
Merged
maugauwi-hash merged 4 commits intoAug 31, 2026
Merged
Conversation
Wire checklist items (no-unwrap/panic, checked arithmetic, must-use token transfer results, heuristic auth/pause guard scan) into a new `security-lints` required job in security.yml, and annotate docs/security-audit-checklist.md with per-item automation status (CI-gated / partial / manual-only) plus a coverage summary table.
scripts/test.sh now supports COVERAGE=1 to run cargo-llvm-cov, emitting lcov + HTML reports and failing under a configurable MIN_COVERAGE floor (default 70%). Add a coverage job to ci.yml that archives the report as a build artifact on every run, and document coverage expectations for new/changed files in docs/best-practices.md.
install-hooks.sh now records a per-hook install result, runs a post-install verification pass (file exists + executable), prints a clear summary of installed vs. failed hooks, and repairs partial installs (e.g. stripped exec bit) on idempotent re-run instead of silently no-op'ing. Add scripts/test-install-hooks.sh, which clones the repo into a temp directory and validates install, idempotent re-run, and partial-install repair from a clean checkout.
Pin scripts/build.sh to rustc 1.96.1 (matching CI), normalize SOURCE_DATE_EPOCH/CARGO_INCREMENTAL/RUSTFLAGS remap-path-prefix so identical source always yields identical bytes, and emit a wasm-hashes.txt manifest after each build. Add .github/workflows/reproducible-build.yml, which builds twice from the same commit with isolated CARGO_HOME dirs and fails CI if the resulting WASM hashes diverge. Document the reproducible build steps in docs/deployment-guide.md.
|
@james2177 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #420
Closes #421
Closes #422
Closes #423