Skip to content

[codex] fix security alerts - #10

Merged
barnabasbusa merged 1 commit into
masterfrom
codex/fix-security-alerts
May 21, 2026
Merged

[codex] fix security alerts#10
barnabasbusa merged 1 commit into
masterfrom
codex/fix-security-alerts

Conversation

@parithosh

Copy link
Copy Markdown
Member

Summary

Mirrors the workflow hardening landed in ethpandaops/assertoor#183, adapted for disruptoor's narrower scope (the existing build-dev.yml is already workflow_dispatch-only with read-only default permissions, so the pull_request_targetpull_request and fork/Docker split parts of the assertoor PR don't apply here).

  • Drops the caller-controlled ref input from _shared-check.yaml and _shared-build.yaml so reusable jobs check out the workflow event SHA instead of arbitrary callee-provided refs.
  • Drops the matching with: ref: from every caller (build-dev.yml, build-master.yml, build-release.yml).
  • Drops the now-unused workflow_dispatch ref input from build-dev.yml — the dispatch already runs against the branch/SHA chosen at trigger time.
  • Switches the internal artifact handoffs (linux amd64/arm64 binaries → docker jobs) to artifact IDs via the upload-step outputs, avoiding artifact-name poisoning.

Validation

  • actionlint clean

🤖 Generated with Claude Code

Mirrors the workflow hardening from ethpandaops/assertoor#183, adapted for
disruptoor's workflow_dispatch-only PR build flow:
- Drop caller-controlled ref inputs from reusable check/build workflows so
  reusable jobs check out the workflow event SHA rather than an arbitrary ref
- Drop the now-unused workflow_dispatch ref input from build-dev.yml
- Switch internal artifact handoffs to artifact IDs to avoid name poisoning
- Reusable workflows already had explicit read-only default permissions

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@barnabasbusa
barnabasbusa merged commit ea777fa into master May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants