Skip to content

feat(discord/build): group image tags into main/minimal sections#155

Merged
barnabasbusa merged 2 commits intomasterfrom
bbusa/build-inline-tag-sections
Apr 22, 2026
Merged

feat(discord/build): group image tags into main/minimal sections#155
barnabasbusa merged 2 commits intomasterfrom
bbusa/build-inline-tag-sections

Conversation

@barnabasbusa
Copy link
Copy Markdown
Contributor

Summary

  • Deterministically sort manifest variants (beaconvalidatorbeacon-minimalvalidator-minimal), so the "primary" image in the completion DM no longer depends on Go's random map iteration order. Previously Prysm could surface *-minimal as the lead image.
  • Inline every tag into the embed as its own fenced code block, grouped into Images and Minimal images fields. Each tag gets a per-block copy icon on hover — the separate Copy tags button and its ephemeral reply are gone.
  • Drop the completed cache, completedBuild type, HandleComponent/lookupCompleted/sweepCompleted/parseComponentID/respondEphemeral and completedRetention const — all only existed to back the button.
  • Single-manifest clients (Geth, Reth, Lighthouse, Besu, Teku, Erigon, Lodestar…) render as one code block under Images, no minimal section.

Example output

Reth (single manifest):

Images

ethpandaops/reth:v1.5.0

Prysm / Nimbus-eth2 (4 manifests):

Images

ethpandaops/prysm-beacon-chain:v1.7.0-alpha.5
ethpandaops/prysm-validator:v1.7.0-alpha.5

Minimal images

ethpandaops/prysm-beacon-chain:v1.7.0-alpha.5-minimal
ethpandaops/prysm-validator:v1.7.0-alpha.5-minimal

Heads up

In-flight DMs (<2h old) that still carry the old Copy tags button will show "This interaction failed" on click, since the handler is gone. New DMs render in the new format.

Test plan

  • Dispatch /build for a single-manifest client (e.g. Reth) and confirm one code block under Images, no minimal section.
  • Dispatch /build for Prysm and confirm field order: Images (beacon, validator) then Minimal images (beacon-minimal, validator-minimal).
  • Dispatch /build for Nimbus-eth2 and confirm both nimbus-eth2 and nimbus-validator-client tags appear correctly grouped.
  • Hover a code block in the DM on desktop and verify the per-block 📋 copy icon copies just that tag.

Sort manifest variants deterministically (beacon → validator →
beacon-minimal → validator-minimal) so the "primary" image on the
completion DM is no longer whichever variant Go's map iterator
yielded first.

Inline every tag into the embed as its own fenced code block, grouped
into "Images" and "Minimal images" fields. This removes the Copy tags
button and the completed-build cache that only existed to back it;
each tag keeps a per-block copy icon on hover.

Single-manifest clients (Geth, Reth, etc.) render as one code block
under "Images" with no minimal section.
@barnabasbusa barnabasbusa requested a review from mattevans as a code owner April 22, 2026 09:37
@barnabasbusa barnabasbusa merged commit eaaf268 into master Apr 22, 2026
4 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/build-inline-tag-sections branch April 22, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants