Annotations First Draft#56
Open
PaulRBerg wants to merge 9 commits intoethsociety:masterfrom
PaulRBerg:annotations
Open
Annotations First Draft#56PaulRBerg wants to merge 9 commits intoethsociety:masterfrom PaulRBerg:annotations
PaulRBerg wants to merge 9 commits intoethsociety:masterfrom
PaulRBerg:annotations
Conversation
Member
|
Sorry for the delay on reviewing this. Can we rebase to master and revert some of the minor changes (packagelock.json, shifting everything over with tabs)? It creates a very large diff and hard to review. We can add those changes back in with another PR later. |
Contributor
Author
|
No worries! I aim to rebase and revert the changes soon. |
Contributor
Author
|
Hey @kfichter, this is done and it only needs your final review. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20. A few notes/ questions: