Couldn't get it to work correctly in my project so had to make all these changes#4
Open
Zae wants to merge 2 commits into
Open
Couldn't get it to work correctly in my project so had to make all these changes#4Zae wants to merge 2 commits into
Zae wants to merge 2 commits into
Conversation
Basic changes:
+ Use $prefix on all jQuery variables
+ Use var print_frame_ref = $print_frame.get(0).contentDocument; to get contentDocument of iframe.
+ Use $print_frame.height($print_frame.contents().height()); to get/set height of iframe contents
+ Also clone() scripts to the iframe, (I needed them for my layout)
+ Use
$('img').on('load', print_frame_ref, function(){
$print_frame.height($print_frame.contents().height());
})
To bind load events of images inside the iframe.
+ Rename distroyPrintPreview to destroyPrintPreview.
+ Rename resize..printPreview.mask to resize.printPreview.mask
NOTE: Uses the new on method so requires jQuery 1.7
…w it worked anyway. Oh well, also ran the code through JsLint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all changes were needed, but I did them anyway to get the code a bit cleaner and easier to understand.
Basic changes:
$('img').on('load', print_frame_ref, function(){
$print_frame.height($print_frame.contents().height());
})
To bind load events of images inside the iframe.
NOTE: Uses the new on method so requires jQuery 1.7