Skip to content

Deduplicate built-in provider default option - #15

Merged
euforic merged 1 commit into
mainfrom
euforic/dedupe-built-in-provider-menu
Sep 1, 2026
Merged

Deduplicate built-in provider default option#15
euforic merged 1 commit into
mainfrom
euforic/dedupe-built-in-provider-menu

Conversation

@euforic

@euforic euforic commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • collapse the built-in provider and default rows when built-in OAuth is the current default
  • preserve the explicit built-in fallback when a named provider is the default
  • normalize existing explicit built-in selections to the unified displayed row

Validation

  • swift test (270 passed, 9 opt-in tests skipped, 0 failures)

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Copilot AI lite review requested due to automatic review settings September 1, 2026 21:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T21:07:08.819425Z ada63fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ada63fb1f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +353 to +356
if let defaultProfile {
"Default — \(defaultProfile.displayName)"
} else {
"Built-in Codex (OAuth) — Default"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the documented provider option names

When no named default exists, the picker now exposes Built-in Codex (OAuth) — Default instead of the README's documented Use Default option, while README.md:86-90 still directs users to choose Use Default. Users following Quick Start therefore cannot find the named control; update the focused documentation with the new conditional labels in this change.

AGENTS.md reference: AGENTS.md:L50-L51

Useful? React with 👍 / 👎.

@euforic
euforic merged commit c1db7f3 into main Sep 1, 2026
2 checks passed
@euforic
euforic deleted the euforic/dedupe-built-in-provider-menu branch September 1, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants