fix(ipad): remove duplicate sidebar toggle button#54
Conversation
NavigationSplitView already injects a sidebar toggle in the detail column's leading toolbar; the manual ToolbarItem with sidebar.left created a second, identical button. Removed the manual button and the now-unused reduceMotion environment property. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe iPad content view implementation has undergone streamlining. Specifically, the environment dependency tracking motion reduction preferences has been removed, along with the toolbar sidebar-toggle button that previously managed column visibility state transitions using motion-based animation utilities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request removes the accessibilityReduceMotion environment property and the custom sidebar toggle button from the ChatView toolbar within iPadContentView.swift. Additionally, there is a minor indentation change for the restoredConversationID property. I have no feedback to provide as there were no review comments.
Summary
NavigationSplitViewautomatically injects a sidebar toggle in the detail column's leading toolbariPadContentView.swiftalso manually added aToolbarItem(placement: .topBarLeading)with asidebar.lefticon, creating a second identical buttonToolbarItemblock and the now-unused@Environment(\.accessibilityReduceMotion)propertyTest plan
AppLaunchConfiguration.isReleaseCaptureMode) still shows detail-only (unaffected, no toggle rendered in that mode)🤖 Generated with Claude Code
Summary by CodeRabbit