Skip to content

fix(ipad): remove duplicate sidebar toggle button#54

Merged
eulicesl merged 2 commits into
mainfrom
fix/ipad-duplicate-sidebar-toggle
Apr 18, 2026
Merged

fix(ipad): remove duplicate sidebar toggle button#54
eulicesl merged 2 commits into
mainfrom
fix/ipad-duplicate-sidebar-toggle

Conversation

@eulicesl

@eulicesl eulicesl commented Apr 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • NavigationSplitView automatically injects a sidebar toggle in the detail column's leading toolbar
  • iPadContentView.swift also manually added a ToolbarItem(placement: .topBarLeading) with a sidebar.left icon, creating a second identical button
  • Removed the manual ToolbarItem block and the now-unused @Environment(\.accessibilityReduceMotion) property

Test plan

  • Open app on iPad — confirm only one sidebar toggle button visible in the toolbar
  • Tap the toggle — sidebar hides/shows correctly
  • Verify release capture mode path (AppLaunchConfiguration.isReleaseCaptureMode) still shows detail-only (unaffected, no toggle rendered in that mode)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Removed the sidebar toggle button from the iPad interface that previously controlled column visibility in the chat view.
    • Removed internal accessibility motion dependency to streamline the codebase.

NavigationSplitView already injects a sidebar toggle in the detail
column's leading toolbar; the manual ToolbarItem with sidebar.left
created a second, identical button. Removed the manual button and
the now-unused reduceMotion environment property.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8664c51d-cae0-4f49-b79a-190fdf6ea01d

📥 Commits

Reviewing files that changed from the base of the PR and between 3a43344 and e90e728.

📒 Files selected for processing (1)
  • Lumen/Views/iOS/iPadContentView.swift

📝 Walkthrough

Walkthrough

The iPad content view implementation has undergone streamlining. Specifically, the environment dependency tracking motion reduction preferences has been removed, along with the toolbar sidebar-toggle button that previously managed column visibility state transitions using motion-based animation utilities.

Changes

Cohort / File(s) Summary
iPad View Simplification
Lumen/Views/iOS/iPadContentView.swift
Removed @Environment accessibility motion dependency, eliminated toolbar button for column visibility toggle (previously switching between .all and .detailOnly states), and pruned associated conditional rendering and accessibility labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A sidebar button fades away,
Motion sensors bid their say,
iPad views, now lean and light,
Simplified to pure delight. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear summary of the problem and solution, but lacks required sections such as Change Type, Scope, Security & Privacy Impact, Repro + Verification, Human Verification, and visual evidence attachments specified in the template. Complete the missing required sections: select Change Type (Bug fix), mark Scope (iPad/macOS UI), provide Security & Privacy Impact assessment, include detailed Repro + Verification steps, confirm Human Verification with specific testing evidence, and attach simulator/device screenshots as evidence.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a duplicate sidebar toggle button from the iPad view, which is the primary objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ipad-duplicate-sidebar-toggle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the accessibilityReduceMotion environment property and the custom sidebar toggle button from the ChatView toolbar within iPadContentView.swift. Additionally, there is a minor indentation change for the restoredConversationID property. I have no feedback to provide as there were no review comments.

@eulicesl
eulicesl merged commit caa8682 into main Apr 18, 2026
5 checks passed
@eulicesl
eulicesl deleted the fix/ipad-duplicate-sidebar-toggle branch April 18, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant