Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens VolumeGrid’s macOS sandbox permissions by removing an unused user-selected file read/write entitlement, aligning the app with least-privilege now that legacy filesystem-related code has been removed.
Changes:
- Removes
com.apple.security.files.user-selected.read-writefromVolumeGrid.entitlements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for the cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VolumeGrid.entitlementsincludescom.apple.security.files.user-selected.read-write, but there are no file system operations anywhere in the current codebase — noFileManager,NSOpenPanel,NSSavePanel, orData(contentsOf:)usage.This entitlement was originally needed for the legacy
LaunchAtLoginControllerwhich managed plist files in~/Library/LaunchAgents/for macOS < 13 support. That code was removed in18156e4(first released in v1.1.1), but the entitlement was not cleaned up at the time.This PR removes it to follow the principle of least privilege.