Open
Conversation
added 2 commits
October 15, 2025 14:33
mayinghan
reviewed
Oct 16, 2025
...ounts__pyroworks__models__swe-1-mtp#accounts__pyroworks__deployments__r5dfiiwp.eval-run.json
Outdated
Show resolved
Hide resolved
…we-1-mtp#accounts__pyroworks__deployments__r5dfiiwp.eval-run.json
xzrderek
reviewed
Oct 16, 2025
Contributor
xzrderek
left a comment
xzrderek
left a comment
There was a problem hiding this comment.
same as other pr, let dylan / benny take a look before merging
dphuang2
reviewed
Oct 17, 2025
dphuang2
reviewed
Oct 17, 2025
dphuang2
reviewed
Oct 17, 2025
dphuang2
reviewed
Oct 17, 2025
| remote_base_url="http://127.0.0.1:3000", | ||
| model_base_url="https://tracing.fireworks.ai", | ||
| timeout_seconds=1800, | ||
| output_data_loader=default_fireworks_output_data_loader, |
Collaborator
There was a problem hiding this comment.
why do you need to specify this? I thought there is a default one
dphuang2
reviewed
Oct 17, 2025
examples/swebench/tracing_model.py
Outdated
| @@ -0,0 +1,159 @@ | |||
| """ | |||
| TracingFireworksModel - Routes through tracing using OpenAI SDK. | |||
Collaborator
There was a problem hiding this comment.
can you give a more comprehensive explanation for this file. current this is confusing for somebody who doesn't know SWE-bench
- Why do we need it?
- What is it doing?
dphuang2
approved these changes
Oct 17, 2025
xzrderek
reviewed
Oct 20, 2025
| max_dataset_rows=2, | ||
| rollout_processor=RemoteRolloutProcessor( | ||
| remote_base_url="http://127.0.0.1:3000", | ||
| model_base_url="https://tracing.fireworks.ai", |
Contributor
There was a problem hiding this comment.
don't think you need this
| if message.startswith("EVAL_RESULT:"): | ||
| result_json = message.replace("EVAL_RESULT:", "") | ||
| row.evaluation_result = EvaluateResult.model_validate_json(result_json) | ||
| break |
Contributor
There was a problem hiding this comment.
hmmm i don't quite get this logic here. i thought we should be reading from the tracing.fireworks.ai, check out default_fireworks_output_data_loader.
Contributor
There was a problem hiding this comment.
maybe i am misunderstanding?
dphuang2
reviewed
Oct 20, 2025
xzrderek
reviewed
Oct 20, 2025
added 2 commits
October 20, 2025 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWE-bench integration into eval-protocol, run swe-bench locally and use our RemoteRolloutProcessor to interact with the server.py