Closed
Conversation
| logger.info(f"Fetching traces for rollout_id '{rollout_id}', expecting {len(expected_ids)} insertion_ids") | ||
| if tracking_key: | ||
| expected_ids = get_insertion_ids(redis_client, tracking_key) | ||
| logger.info(f"Fetching traces for {tracking_label} '{tracking_key}', expecting {len(expected_ids)} insertion_ids") |
There was a problem hiding this comment.
Bug: Missing variable definitions in fetch_langfuse_traces function
The fetch_langfuse_traces function uses tracking_key and tracking_label variables (at lines 254, 256, 259, 263, 280, 336, 356, 373, 378, 382) but these are never defined in this function. The function only extracts rollout_id at line 226. The corresponding pointwise_fetch_langfuse_trace function was correctly updated to define both tracking_key and tracking_label from trail_id and rollout_id, but this definition block was not added to fetch_langfuse_traces. This will cause a NameError at runtime when accessing the trail traces endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Add trail_id-based chat and traces endpoints with Langfuse tagging and Redis tracking, while keeping legacy rollout routes intact.
/trails/{trail_id}/chat/completions(+v1andproject_idvariants)./trails/{trail_id}/tracesand/trails/{trail_id}/traces/pointwise(+ variants).trail_idandinsertion_idtags for trail requests; retain rollout tag set for legacy paths.tracking_key(trail_id or rollout_id) for insertion IDs.tracking_keyin logs, completeness checks, and pointwise latest-trace fetch.ChatParamswith optionaltrail_id.Written by Cursor Bugbot for commit 911daca. This will update automatically on new commits. Configure here.