Open
Conversation
| "stream": True, | ||
| "temperature": 0.0, | ||
| "max_tokens": DEFAULT_MAX_TOKENS, | ||
| "reasoning_effort": "none", |
There was a problem hiding this comment.
Bug: New tool_choice tests hardcode reasoning_effort unconditionally
The new tool_choice tests (test_streaming_tool_choice_none, test_non_streaming_tool_choice_none, test_streaming_tool_choice_required, test_non_streaming_tool_choice_required) hardcode "reasoning_effort": "none" in their completion_params. This contradicts the SUPPORTS_REASONING feature flag design, which states that when EP_SUPPORTS_REASONING=0, the reasoning_effort parameter should NOT be passed at all. These tests should use _maybe_add_reasoning_effort to conditionally include the parameter, matching the pattern used by other tests in this file.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds feature-flagged reasoning and multi-tool support, introduces tool_choice (none/required) tests, and uses raw_output with conditional reasoning handling across streaming and non-streaming benchmarks.
Feature Flags & Infra:
SUPPORTS_MULTIPLE_TOOL_CALLSandSUPPORTS_REASONINGwithpytest.mark.skipifgating.ChatCompletionContentPartTextParamwithChatCompletionContentPartParam._maybe_add_reasoning_effortand passreasoning_effortconditionally; extend passthrough totool_choice.raw_output=Truebroadly to inspect prompts; add checks againstraw_output.prompt_fragments.Tests Added/Expanded:
tool_choice=noneandtool_choice=required(streaming and non-streaming) ensuring no/required tool calls and prompt hygiene.Validation/Metrics Adjustments:
raw_output, refining finish_reason expectations).Written by Cursor Bugbot for commit 982eba2. This will update automatically on new commits. Configure here.