Klavis Sandbox on Fireworks EP#388
Merged
xzrderek merged 2 commits intoeval-protocol:mainfrom Dec 29, 2025
Merged
Conversation
| @@ -1,5 +1,6 @@ | |||
| from .default_agent_rollout_processor import AgentRolloutProcessor | |||
| from .default_dataset_adapter import default_dataset_adapter | |||
| from .default_klavis_sandbox_rollout_processor import KlavisSandboxRolloutProcessor | |||
There was a problem hiding this comment.
Missing try/except for optional klavis dependency import
The KlavisSandboxRolloutProcessor is imported unconditionally at line 3, but it depends on the optional klavis package. This will cause an ImportError for any user who imports from eval_protocol.pytest without having klavis installed. Other optional dependency imports like PydanticAgentRolloutProcessor and LangGraphRolloutProcessor are correctly wrapped in try/except blocks (lines 16-22 and 25-31), but KlavisSandboxRolloutProcessor lacks this protection. The import and __all__ export at line 35 both need to be made conditional like the other optional dependencies.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Integrates Klavis sandbox lifecycle into EP pytest utilities and provides a working Gmail sandbox eval.
KlavisSandboxRolloutProcessormanages full sandbox flow: create/init (initialize_*_sandbox), generate temp MCP config, runAgent, export/dump sandbox state, attach results torow.execution_metadata.extra, cleanup and delete sandboxKlavisSandboxRolloutProcessorviaeval_protocol.pytest.__init__klavisdependency group (klavis>=2.18.0) and lockfile updatestest_pytest_klavis_sandbox.pyand datasetklavis_gmail_sandbox_test.jsonl: adapts JSONL to EP rows, runs againstserver_name="gmail", and scores via Fireworks LLM by comparing dumped sandbox state to providedground_truthWritten by Cursor Bugbot for commit 7f35e24. This will update automatically on new commits. Configure here.
See our slack channel for demo