Conversation
| const extraInput = | ||
| info.extras && typeof info.extras === 'object' && !Array.isArray(info.extras) | ||
| ? info.extras | ||
| : {}; |
There was a problem hiding this comment.
Unhandled JSON serialization error in debug logging path
The new extraInput spread at lines 213-216 allows arbitrary user-provided values into the payload. If these contain non-serializable values (BigInt, circular references, functions), the JSON.stringify(payload).length call at line 101 will throw outside the try-catch block. This only happens when EP_DEBUG is true, but unlike the Python implementation which wraps debug logging in try-except, the TypeScript version lacks this protection. The error propagates as an event rather than being silently handled as intended.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds flexible metadata support in logging and normalizes adapter responses.
FireworksTracingHttpHandlerandFireworksTransportto merge user-providedextrasintoextraspayload alongsidelogger_name,level,timestampFireworksTracingAdapter.search_logsto includestatusandextrasin normalized resultstypescript/package.jsonto version0.1.11and formatfilesarrayWritten by Cursor Bugbot for commit 02b05ea. This will update automatically on new commits. Configure here.