Stop ignoring .dockerignore files during evaluator uploads#397
Merged
Conversation
dphuang2
approved these changes
Jan 7, 2026
Collaborator
dphuang2
left a comment
There was a problem hiding this comment.
good change, we should never have been using dockerignore for filtering uploaded files
xzrderek
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pre-commit run --files eval_protocol/evaluation.py tests/test_ep_upload_e2e.pypytest tests/test_ep_upload_e2e.py::test_create_tar_includes_dockerignored_files(fails: ModuleNotFoundError: No module named 'litellm')Codex Task
Note
Behavior change
.gitignore;.dockerignorepatterns are no longer applied when creating evaluator upload archives (_create_tar_gz_with_ignores).Tests
test_create_tar_includes_dockerignored_filesto confirm files listed in.dockerignore(e.g.,Dockerfile, dirs) are still included in the tarball.tarfile).Written by Cursor Bugbot for commit 236147f. This will update automatically on new commits. Configure here.