Skip to content

Stop ignoring .dockerignore files during evaluator uploads#397

Merged
benjibc merged 1 commit intomainfrom
codex/fix-.dockerignore-handling-in-sdk
Jan 8, 2026
Merged

Stop ignoring .dockerignore files during evaluator uploads#397
benjibc merged 1 commit intomainfrom
codex/fix-.dockerignore-handling-in-sdk

Conversation

@benjibc
Copy link
Contributor

@benjibc benjibc commented Jan 7, 2026

Summary

  • remove .dockerignore patterns from the evaluator upload archive so all files are sent prior to build-time ignores
  • add a regression test confirming dockerignored files remain in the upload tarball

Testing

  • pre-commit run --files eval_protocol/evaluation.py tests/test_ep_upload_e2e.py
  • pytest tests/test_ep_upload_e2e.py::test_create_tar_includes_dockerignored_files (fails: ModuleNotFoundError: No module named 'litellm')

Codex Task


Note

Behavior change

  • Packaging now respects only .gitignore; .dockerignore patterns are no longer applied when creating evaluator upload archives (_create_tar_gz_with_ignores).

Tests

  • Add test_create_tar_includes_dockerignored_files to confirm files listed in .dockerignore (e.g., Dockerfile, dirs) are still included in the tarball.
  • Minor test adjustments (import tarfile).

Written by Cursor Bugbot for commit 236147f. This will update automatically on new commits. Configure here.

Copy link
Collaborator

@dphuang2 dphuang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change, we should never have been using dockerignore for filtering uploaded files

@benjibc benjibc enabled auto-merge (squash) January 8, 2026 00:28
@benjibc benjibc merged commit 5e31311 into main Jan 8, 2026
30 of 33 checks passed
@benjibc benjibc deleted the codex/fix-.dockerignore-handling-in-sdk branch January 8, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants