Skip to content

ensure logs are json serializable #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 1 commit into from
Jan 7, 2026
Merged

ensure logs are json serializable #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions typescript/logging/fireworks-transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,23 @@ export class FireworksTransport extends Transport {
const baseUrl = this.gatewayBaseUrl.replace(/\/$/, '');
const url = `${baseUrl}/logs`;

let payloadJson: string;
try {
payloadJson = JSON.stringify(payload);
} catch (e: any) {
const msg = `Fireworks logging payload is not JSON-serializable (rollout_id=${rolloutId}): ${e?.message || e}`;
console.error(`[FW_LOG] ${msg}`);
this.emit('error', new Error(msg));
return;
}

// Debug logging
if (process.env.EP_DEBUG === 'true') {
const tagsLen = Array.isArray(payload.tags) ? payload.tags.length : 0;
const msgPreview = typeof payload.message === 'string'
? payload.message.substring(0, 80)
: payload.message;
const payloadSize = JSON.stringify(payload).length;
const payloadSize = payloadJson.length;
const hasStatus = !!payload.status;
console.log(`[FW_LOG] POST ${url} rollout_id=${rolloutId} tags=${tagsLen} msg=${msgPreview} size=${payloadSize} hasStatus=${hasStatus}`);
}
Expand All @@ -116,7 +126,7 @@ export class FireworksTransport extends Transport {
const response = await fetch(url, {
method: 'POST',
headers,
body: JSON.stringify(payload),
body: payloadJson,
// No timeout signal for compatibility
});

Expand All @@ -136,7 +146,7 @@ export class FireworksTransport extends Transport {
const retryResponse = await fetch(altUrl, {
method: 'POST',
headers,
body: JSON.stringify(payload),
body: payloadJson,
// No timeout signal for compatibility
});

Expand All @@ -149,7 +159,7 @@ export class FireworksTransport extends Transport {
// Silently handle errors - logging should not break the application
if (process.env.EP_DEBUG === 'true') {
console.error(`[FW_LOG] Error sending to Fireworks:`, error.message);
console.error(`[FW_LOG] Payload was:`, JSON.stringify(payload, null, 2));
console.error(`[FW_LOG] Payload was:`, payloadJson);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"files": [
"dist"
],
"version": "0.1.11",
"version": "0.1.12",
"peerDependencies": {
"typescript": "^5",
"@vercel/functions": "^1.4.0",
Expand Down
Loading