Conversation
added 3 commits
January 16, 2026 10:47
- Introduced `--env-file` argument in the CLI for specifying the path to the .env file containing secrets. - Refactored the upload process to include a new function `upload_secrets_to_fireworks` that handles the uploading of secrets. - Updated the `upload_command` to optionally skip secret uploads if already handled. - Enhanced the evaluator upload process to ensure secrets are uploaded before ensuring evaluator existence.
…ed first - Moved the call to `upload_secrets_to_fireworks` to occur before checking the evaluator status, ensuring that secrets are available for evaluation. - Removed redundant upload of secrets that was previously placed after the evaluator existence check.
- Implemented functions to check for existing secrets on Fireworks and confirm overwriting them with user prompts. - Updated the secret selection process to deselect existing secrets by default, enhancing user experience and preventing accidental overwrites. - Refactored the `upload_secrets_to_fireworks` function to incorporate these changes, ensuring a safer and more intuitive secret management workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--env-fileargument in the CLI for specifying the path to the .env file containing secrets.upload_secrets_to_fireworksthat handles the uploading of secrets.upload_commandto optionally skip secret uploads if already handled.Note
Improves secrets management and evaluator creation flow.
--env-filetocreate rftfor specifying a secrets file; secrets are now uploaded before evaluator checks/uploadsupload_secrets_to_fireworksand integrates it into bothupload(optional viaskip_secrets) andcreate rftpathsget_fireworks_secret, deselects them by default in prompts, and adds double-confirmation before overwriting[exists], defaults to only new secrets in non-questionary fallback, and improves masked logging_upload_and_ensure_evaluatorto acceptenv_file/non_interactiveand to callupload_command(..., skip_secrets=True)Written by Cursor Bugbot for commit 39189e8. This will update automatically on new commits. Configure here.