Skip to content

add finish reason#421

Merged
xzrderek merged 6 commits intomainfrom
derekx/add-finish_reason
Jan 26, 2026
Merged

add finish reason#421
xzrderek merged 6 commits intomainfrom
derekx/add-finish_reason

Conversation

@xzrderek
Copy link
Contributor

@xzrderek xzrderek commented Jan 26, 2026

Note

Adds finish reason capture to evaluation rows and surfaces necessary metadata for parsing.

  • Adapter now parses raw_gen_ai_request OTEL span attributes to set execution_metadata.finish_reason (e.g., from llm.openai.choices)
  • Proxy langfuse serializer includes observation metadata, enabling the adapter’s parsing logic
  • Improves observations handling with or [] fallbacks; minor cleanup
  • Remote server test config updated to ensure INFO logs; new assertions verify receipt of status logs and that finish_reason == "stop"

Written by Cursor Bugbot for commit b35c4bc. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

@xzrderek xzrderek merged commit 1d07878 into main Jan 26, 2026
13 of 17 checks passed
@xzrderek xzrderek deleted the derekx/add-finish_reason branch January 26, 2026 23:37
xzrderek added a commit that referenced this pull request Mar 10, 2026
xzrderek added a commit that referenced this pull request Mar 10, 2026
* Revert "use litellm sdk (#424)"

This reverts commit acba670.

* Revert "add finish reason (#421)"

This reverts commit 1d07878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant