Open
Conversation
| # Retry configuration for 404 errors | ||
| # 8 retries with exponential backoff (1, 2, 4, 8, 16, 32, 64, 128 seconds) | ||
| # Total wait time: ~255 seconds (~4.25 minutes) | ||
| MAX_RETRIES_ON_404 = 9 |
There was a problem hiding this comment.
Retry count mismatch: 9 retries instead of documented 8
Medium Severity
The comment states "8 retries" with delays of "1, 2, 4, 8, 16, 32, 64, 128 seconds" and total wait time of "~255 seconds", but MAX_RETRIES_ON_404 = 9 causes 9 retries. The 9th retry adds a 256-second delay, nearly doubling total wait time to ~511 seconds (~8.5 minutes). This could cause users to wait twice as long as intended when hitting persistent 404 errors.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds resilience to LiteLLM chat forwarding.
handle_chat_completionwith exponential backoff (up to 9 attempts; ~4.25 min max) usingasyncio.sleepMAX_RETRIES_ON_404andRETRY_BASE_DELAY_SECONDSconstants; sets JSON headers explicitlyinsertion_idregistration logic remain unchangedWritten by Cursor Bugbot for commit 9186f68. This will update automatically on new commits. Configure here.