fix: restore logging.basicConfig in test remote servers#435
Merged
Conversation
The revert in #434 accidentally removed the `logging.basicConfig(level=logging.INFO)` call from the test remote servers. Without it, the root logger defaults to WARNING, which silently drops the `logger.info()` call that emits `Status.rollout_finished()`. The FireworksTracingHttpHandler never fires, no POST /logs is made, and the RemoteRolloutProcessor polling loop times out after 180 seconds. This restores the original line (with its explanatory comment) in both remote_server.py and remote_server_multi_turn.py. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logging.basicConfig(level=logging.INFO)call that was accidentally removed in revert #434 (revert PR)WARNING, silently dropping thelogger.info()call that emitsStatus.rollout_finished()viaFireworksTracingHttpHandlerRemoteRolloutProcessorpolling loop to time out after 180s instead of finding the status log in ~1sRoot Cause
The revert in #434 reverted two PRs but also removed the logging config line as collateral damage. The
FireworksTracingHttpHandleris attached to the root logger, butlogger.info()(level 20) is below the root logger's defaultWARNING(level 30), so the log record is discarded before it ever reaches the handler. NoPOST /logsis made to the tracing gateway, and the polling loop gets empty 192-byte responses until it times out.The error path (
logger.error()) was unaffected becauseERROR(40) >=WARNING(30).Test plan
test_remote_fireworksshould complete in ~10-30s instead of timing out at 180stest_remote_fireworks_propagate_statusshould continue to pass as beforeMade with Cursor
Note
Low Risk
Low risk: test-only change that restores
INFO-level logging so rollout status events reach the tracing handler; behavior impact is limited to remote-server test harnesses.Overview
Restores explicit
logging.basicConfig(level=logging.INFO, ...)in the test remote servers sologger.info()messages are emitted.This ensures
FireworksTracingHttpHandlerattached to the root logger receives theStatus.rollout_finished()info log, preventing remote rollout polling from timing out during tests.Written by Cursor Bugbot for commit 0df74b7. This will update automatically on new commits. Configure here.