The expected URL could also have a tailing slash for github task missing-semester/find_legacy_name#193
Merged
zjwu0522 merged 2 commits intoeval-sys:mainfrom Sep 15, 2025
LLiuZheng:main
Merged
The expected URL could also have a tailing slash for github task missing-semester/find_legacy_name#193zjwu0522 merged 2 commits intoeval-sys:mainfrom LLiuZheng:main
zjwu0522 merged 2 commits intoeval-sys:mainfrom
LLiuZheng:main
Conversation
…g slash could also be found in the template commit.
zjwu0522
approved these changes
Sep 15, 2025
Collaborator
zjwu0522
left a comment
zjwu0522
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the fix. Approving.
Collaborator
|
Just added a small style cleanup, your fix looks great 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template containing the second URL.
I didn't see any URL format requirement in the task description, so it should also be considered as a correct answer.