Skip to content

[Fix]Accurate Fuel Economy Calculations Across Unit Systems#76

Open
asadsaifi2021 wants to merge 1 commit into
evancharlton:masterfrom
asadsaifi2021:master
Open

[Fix]Accurate Fuel Economy Calculations Across Unit Systems#76
asadsaifi2021 wants to merge 1 commit into
evancharlton:masterfrom
asadsaifi2021:master

Conversation

@asadsaifi2021

Copy link
Copy Markdown

Fix: Accurate Fuel Economy Calculations Across Unit Systems

Problem:
The app currently produces incorrect fuel economy values when switching between metric/imperial systems due to:

  • Early rounding in calculation chain
  • Unit conversions happening at wrong stages
  • No dedicated test coverage

Changes Made:

  • Created new FuelEfficiencyCalculator class to centralize all economy math
  • Separated unit conversion from core calculations
  • Maintained full precision until final display rounding
  • Added comprehensive JUnit tests covering:
    • Imperial (MPG) and metric (km/L) modes
    • Unit system conversions
    • Partial fillup edge cases
    • Zero-distance/volume scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant