Skip to content

Config UI: network settings on fatal#28501

Open
naltatis wants to merge 1 commit intomasterfrom
fix/network_fatal
Open

Config UI: network settings on fatal#28501
naltatis wants to merge 1 commit intomasterfrom
fix/network_fatal

Conversation

@naltatis
Copy link
Member

@naltatis naltatis commented Mar 23, 2026

Ensure that db network settings are applied early and are not skipped due to other errors (expired sponsor token). Moved settings read directly behind db-init.

see #22961 (reply in thread)

\cc @deify

@naltatis naltatis requested a review from andig March 23, 2026 16:58
@naltatis naltatis added the bug Something isn't working label Mar 23, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deify
Copy link

deify commented Mar 23, 2026

Looks good. I don't have an expired token around to test this, but configuring network as early as possible (after the db is ready) seems valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants