Do *not* use the titleized name of the metric because it can contain spaces#21
Open
tdevelioglu wants to merge 1 commit intoevenup:masterfrom
Open
Do *not* use the titleized name of the metric because it can contain spaces#21tdevelioglu wants to merge 1 commit intoevenup:masterfrom
tdevelioglu wants to merge 1 commit intoevenup:masterfrom
Conversation
spaces. The titleized name of a metric is its name with underscores replaced with spaces and the first word capitalized. This causes metrics for resources with underscores in the name not to work because graphite doesn't allow spaces in metric names. This commit changes the report processor to use the standard name instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The titleized name of a metric is its name with underscores replaced
with spaces and the first word capitalized. This causes metrics for
resources with underscores in the name not to work because graphite
doesn't allow spaces in metric names.
This commit changes the report processor to use the standard name instead.