chore: consolidate demos — drop redundant ManualSectionDemo#16
Merged
Conversation
ManualSectionDemo's showcase (manual sections, counters, async, threads, guided UI) is fully covered by AppleTraceSwiftDemo's richer Swift workload (withSpan + counters/instants/async) and it had no CI/script dependency, so it was the redundant sample. The repo now ships two demos with no loss of feature coverage: - sample/AppleTraceSwiftDemo — withSpan + @Traced/@traceall macros, counters/async, and the AppleTraceAuto SwiftTrace hook. - sample/TraceAllMsgDemo — manual APTBeginSection sections AND the automatic objc_msgSend hook (kept: unique feature + wired into the objc-msgsend CI smoke tests and the device script). Updated all references: README, README_CN, AGENT.md, and the Tutorial site (index.html / zh.html) — demo tables, framework-embedding pointers, and project-structure trees. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three sample apps overlapped. No single demo covers everything (the
objc_msgSendhook is unique toTraceAllMsgDemoand is wired into CI), butManualSectionDemo's manual-sections + counters/async + guided-UI showcase is fully covered by the richer Swift demo. It also had no CI/script dependency, making it the redundant one.Change
Reduce 3 → 2 samples with no loss of feature coverage:
sample/AppleTraceSwiftDemowithSpan+@Traced/@TraceAll, counters/async, and theAppleTraceAutoSwiftTrace hooksample/TraceAllMsgDemoAPTBeginSectionsections and the automaticobjc_msgSendhookTraceAllMsgDemostays because it owns theobjc_msgSendhook demo and is built/run by theobjc-msgsend-smoke/objc-msgsend-experimentalCI jobs andscripts/test_objc_msgsend_hook*.sh.All references updated: README / README_CN (demo tables, framework-embedding pointers, project-structure trees), AGENT.md, and the Tutorial site (
index.html/zh.html). No remainingManualSectionDemoreferences; both tutorial pages re-validated.🤖 Generated with Claude Code